[llvm-commits] [llvm] r56823 - /llvm/trunk/lib/Target/X86/X86FastISel.cpp

[Dan Gohman]

Author: djg
Date: Mon Sep 29 19:48:39 2008
New Revision: 56823

URL: http://llvm.org/viewvc/llvm-project?rev=56823&view=rev
Log:
Disable all x87 usage, including f32 and f64 when the subtarget
doesn't have SSE(2), with X86FastISel.

Modified:
    llvm/trunk/lib/Target/X86/X86FastISel.cpp

Modified: llvm/trunk/lib/Target/X86/X86FastISel.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FastISel.cpp?rev=56823&r1=56822&r2=56823&view=diff

==============================================================================
--- llvm/trunk/lib/Target/X86/X86FastISel.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86FastISel.cpp Mon Sep 29 19:48:39 2008
@@ -123,10 +123,12 @@
       (VT == MVT::f32 && X86ScalarSSEf32);   // f32 is when SSE1
   }
 
+  bool isTypeLegal(const Type *Ty, const TargetLowering &TLI, MVT &VT,
+                   bool AllowI1 = false);
 };
 
-static bool isTypeLegal(const Type *Ty, const TargetLowering &TLI, MVT &VT,
-                        bool AllowI1 = false) {
+bool X86FastISel::isTypeLegal(const Type *Ty, const TargetLowering &TLI,
+                              MVT &VT, bool AllowI1) {
   VT = MVT::getMVT(Ty, /*HandleUnknown=*/true);
   if (VT == MVT::Other || !VT.isSimple())
     // Unhandled type. Halt "fast" selection and bail.
@@ -134,6 +136,15 @@
   if (VT == MVT::iPTR)
     // Use pointer type.
     VT = TLI.getPointerTy();
+  // For now, require SSE/SSE2 for performing floating-point operations,
+  // since x87 requires additional work.
+  if (VT == MVT::f64 && !X86ScalarSSEf64)
+     return false;
+  if (VT == MVT::f32 && !X86ScalarSSEf32)
+     return false;
+  // Similarly, no f80 support yet.
+  if (VT == MVT::f80)
+    return false;
   // We only handle legal types. For example, on x86-32 the instruction
   // selector contains all of the 64-bit instructions from x86-64,
   // under the assumption that i64 won't be used if the target doesn't
@@ -516,8 +527,8 @@
 bool X86FastISel::X86SelectCmp(Instruction *I) {
   CmpInst *CI = cast<CmpInst>(I);
 
-  MVT VT = TLI.getValueType(I->getOperand(0)->getType());
-  if (!TLI.isTypeLegal(VT))
+  MVT VT;
+  if (!isTypeLegal(I->getOperand(0)->getType(), TLI, VT))
     return false;
 
   unsigned Op0Reg = getRegForValue(CI->getOperand(0));
@@ -728,7 +739,7 @@
   }
 
   MVT VT = MVT::getMVT(I->getType(), /*HandleUnknown=*/true);
-  if (VT == MVT::Other || !TLI.isTypeLegal(VT))
+  if (VT == MVT::Other || !isTypeLegal(I->getType(), TLI, VT))
     return false;
 
   unsigned Op0Reg = getRegForValue(I->getOperand(0));
@@ -773,7 +784,7 @@
   }
 
   MVT VT = MVT::getMVT(Ty, /*HandleUnknown=*/true);
-  if (VT == MVT::Other || !TLI.isTypeLegal(VT))
+  if (VT == MVT::Other || !isTypeLegal(Ty, TLI, VT))
     return false;
 
   unsigned Op0Reg = getRegForValue(I->getOperand(0));