[llvm-commits] [llvm] r56716 - in /llvm/trunk: docs/ include/llvm/ lib/AsmParser/ lib/Target/X86/AsmPrinter/ lib/Transforms/IPO/ lib/Transforms/Scalar/ lib/Transforms/Utils/ lib/VMCore/ test/CodeGen/ARM/ test/Transforms/Inline/

[Devang Patel]

On Sep 29, 2008, at 12:38 AM, Duncan Sands wrote:

> Hi Devang,
>
>> +<dt><tt>alwaysinline</tt></dt>
>> +<dd>This attribute requests inliner to inline this function  
>> irrespective of
>> +inlining size threshold for this function.</dd>
>
> probably best not to talk about thresholds here.  How about:
> "This attribute instructs the inliner to always inline this function  
> if it can".

I think, it is a good idea to  give them an idea of what is influenced  
here.

>> +<dd>This attribute suggests optimization passes and code generator  
>> passes to
>> +make choices that help reduce code size.</dd>
>
> How about:
> "This attribute tells the optimizers and code generators that  
> reducing code
> size is more important than making the function fast".

What is the difference ?

>> +<dt><tt>noreturn</tt></dt>
>> +<dd>This function attribute indicates that the function never  
>> returns. This
>> +  indicates to LLVM that every call to this function should be  
>> treated as if
>> +  an <tt>unreachable</tt> instruction immediately followed the  
>> call.</dd>
>
> function attribute -> attribute

This is not a parameter attribute. This is not a return attribute.  
This is a function attribute.

>
> This indicates to LLVM -> This tells LLVM

ok

>
>
>> +<dt><tt>nounwind</tt></dt>
>> +<dd>This function attribute indicates that no exceptions unwind  
>> out of the
>> +  function.  Usually this is because the function makes no use of  
>> exceptions,
>
> function attribute -> attribute
>
>> +<dt><tt>readonly</tt></dt>
>> +<dd>This function attribute indicates that the function has no  
>> side-effects
>> +  except for producing a return value or throwing an exception.   
>> The value
>
> function attribute -> attribute
>
>> +  /// hasFnAttr - Return true if this function has given attribute.
>
> given attribute -> the given attribute

ok
>
>
> Ciao,
>
> Duncan.

-
Devang