[llvm-commits] [llvm] r56610 - in /llvm/trunk: include/llvm/CodeGen/FastISel.h lib/CodeGen/SelectionDAG/FastISel.cpp lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp

Chris Lattner clattner at apple.com
Thu Sep 25 10:16:08 PDT 2008


On Sep 25, 2008, at 10:05 AM, Dan Gohman wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=56610&view=rev
> Log:
> FastISel support for debug info.

> +bool FastISel::SelectCall(User *I) {
> +  Function *F = cast<CallInst>(I)->getCalledFunction();

FWIW, Call's can never be ConstantExprs.  It might be better to type  
SelectCall as taking a CallInst, and put the cast in the caller.

>
>           // Then handle certain instructions as single-LLVM- 
> Instruction blocks.
>           if (isa<CallInst>(BI)) {
> +            cerr << "FastISel missed call: ";
> +            BI->dump();
> +
>             if (BI->getType() != Type::VoidTy) {
>               unsigned &R = FuncInfo->ValueMap[BI];

Should this be guarded by a DEBUG?

-Chris



More information about the llvm-commits mailing list