[llvm-commits] [llvm] r56463 - in /llvm/trunk: tools/llvmc2/doc/LLVMC-Reference.rst utils/TableGen/LLVMCConfigurationEmitter.cpp

Mikhail Glushenkov foldr at codedgers.com
Mon Sep 22 13:48:23 PDT 2008


Author: foldr
Date: Mon Sep 22 15:48:22 2008
New Revision: 56463

URL: http://llvm.org/viewvc/llvm-project?rev=56463&view=rev
Log:
Make comments a little bit more clear.

Modified:
    llvm/trunk/tools/llvmc2/doc/LLVMC-Reference.rst
    llvm/trunk/utils/TableGen/LLVMCConfigurationEmitter.cpp

Modified: llvm/trunk/tools/llvmc2/doc/LLVMC-Reference.rst
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvmc2/doc/LLVMC-Reference.rst?rev=56463&r1=56462&r2=56463&view=diff

==============================================================================
--- llvm/trunk/tools/llvmc2/doc/LLVMC-Reference.rst (original)
+++ llvm/trunk/tools/llvmc2/doc/LLVMC-Reference.rst Mon Sep 22 15:48:22 2008
@@ -375,16 +375,16 @@
 
   - ``input_languages_contain`` - Returns true if a given language
     belongs to the current input language set. Example:
-    ```(input_languages_contain "c++")``.
+    ``(input_languages_contain "c++")``.
 
   - ``in_language`` - Evaluates to true if the language of the input
-    file equals to the argument. Valid only when using ``case``
-    expression in a ``cmd_line`` tool property. Example:
-    ```(in_language "c++")``.
+    file equals to the argument. At the moment works only with
+    ``cmd_line`` property on non-join nodes. Example: ``(in_language
+    "c++")``.
 
   - ``not_empty`` - Returns true if a given option (which should be
     either a parameter or a parameter list) is set by the
-    user. Example: ```(not_empty "o")``.
+    user. Example: ``(not_empty "o")``.
 
   - ``default`` - Always evaluates to true. Should always be the last
     test in the ``case`` expression.

Modified: llvm/trunk/utils/TableGen/LLVMCConfigurationEmitter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/LLVMCConfigurationEmitter.cpp?rev=56463&r1=56462&r2=56463&view=diff

==============================================================================
--- llvm/trunk/utils/TableGen/LLVMCConfigurationEmitter.cpp (original)
+++ llvm/trunk/utils/TableGen/LLVMCConfigurationEmitter.cpp Mon Sep 22 15:48:22 2008
@@ -826,8 +826,10 @@
     O << "InLangs.count(\"" << OptName << "\") != 0";
     return true;
   } else if (TestName == "in_language") {
-    // TODO: remove this restriction
-    // Works only for cmd_line!
+    // This works only for single-argument Tool::GenerateAction. Join
+    // tools can process several files in different languages simultaneously.
+
+    // TODO: make this work with Edge::Weight (if possible).
     O << "LangMap.GetLanguage(inFile) == \"" << OptName << '\"';
     return true;
   } else if (TestName == "not_empty") {





More information about the llvm-commits mailing list