[llvm-commits] [llvm] r56326 - in /llvm/trunk: include/llvm/CodeGen/LiveInterval.h include/llvm/CodeGen/LiveIntervalAnalysis.h lib/CodeGen/LiveInterval.cpp lib/CodeGen/LiveIntervalAnalysis.cpp lib/CodeGen/RegAllocLinearScan.cpp

[Evan Cheng]

On Sep 21, 2008, at 6:07 PM, Chris Lattner wrote:

> On Sep 19, 2008, at 11:26 AM, Dale Johannesen wrote:
>>>> On Sep 19, 2008, at 10:48 AMPDT, Evan Cheng wrote:
>>>>>>
>>>>>> float weight;        // weight of this interval
>>>>>> +    bool isEarlyClobber;
>>>>>> +    bool overlapsEarlyClobber;
>>>>>
>>>>> Hi Dale,
>>>>>
>>>>> I don't think we want two bits. I'd rather go with one bit and  
>>>>> have
>>>>> register allocator look at both use and def operands. What do you
>>>>> think?
>>>>
>>>> The comment explains why I don't want to do this:
>>>
>>> Sorry, I don't follow. Can you provide an example?
>>
>> void foo (int x, int y) {
>>  int z=x+y;
>>  int w=x+y;
>>  int t;
>>  asm volatile ("%0 %1 %2" : "=&r"(t) : "r"(z), "r"(w));
>> }
>>
>> %1 and %2 can share a register, but if there is no way to distinguish
>> between earlyclobber and overlaps-earlyclobber, we can't do this.
>> In theory this is a matter of correctness, it is possible to  
>> construct
>> cases where you run out of registers if you don't share.
>
> I don't get this at all.  How can a *live interval* be an
> earlyclobber?  It seems that the easy and natural way to model this is
> that the def starts one notch earlier in the use slot of an
> instruction, instead of it's normal place (the def slot).
>
> In other words, I don't understand why this needs to be modeled
> explicitly in live intervals, the construction of live intervals
> should just handle the early clobber def as starting one slot early.

As I said in another email, that's the right solution except it breaks  
liveintervalanalysis and coalescer assumptions. It's possible to try  
that approach but we don't have enough test coverage for early clobber.

Evan

>
>
> -Chris
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits