[llvm-commits] [llvm] r55859 - in /llvm/trunk: include/llvm/Analysis/CallGraph.h lib/Analysis/IPA/CallGraph.cpp lib/Transforms/IPO/PruneEH.cpp lib/Transforms/Utils/InlineFunction.cpp

Chris Lattner clattner at apple.com
Sun Sep 21 14:34:35 PDT 2008


On Sep 5, 2008, at 2:43 PM, Duncan Sands wrote:

> Author: baldrick
> Date: Fri Sep  5 16:43:04 2008
> New Revision: 55859
>
> URL: http://llvm.org/viewvc/llvm-project?rev=55859&view=rev
> Log:
> Delete the removeCallEdgeTo callgraph method,
> because it does not maintain a correct list
> of callsites.  I discovered (see following
> commit) that the inliner will create a wrong
> callgraph if it is fed a callgraph with
> correct edges but incorrect callsites.  These
> were created by Prune-EH, and while it wasn't
> done via removeCallEdgeTo, it could have been
> done via removeCallEdgeTo, which is an accident
> waiting to happen.  Use removeCallEdgeFor
> instead.

Nice!  Does this allow the patch in http://llvm.org/bugs/show_bug.cgi?id=2221 
  to go in now?

-Chris



More information about the llvm-commits mailing list