[llvm-commits] [llvm] r55794 - in /llvm/trunk/lib/Target/X86/AsmPrinter: X86ATTAsmPrinter.cpp X86IntelAsmPrinter.cpp

[Chris Lattner]

On Sep 5, 2008, at 1:00 AM, Duncan Sands wrote:

> Hi Devang,
>
>>   unsigned FnAlign = OptimizeForSize ? 1 : 4;
>> +  if (FnAlign == 4 && (F->getNotes() & FN_NOTE_OptimizeForSize))
>> +    FnAlign = 1;
>
> There's no point in testing that FnAlign == 4 here.  I appreciate
> that you may be trying for a small speedup, but it just makes the
> code more fragile.

Devang, ping.  Better yet, this should be:

unsigned FnAlign = (OptimizeForSize || F- 
 >hasNote(FN_NOTE_OptimizeForSize)) ? 1 : 4;

and eventually OptimizeForSize goes away.

-Chris