[llvm-commits] [llvm] r55973 - in /llvm/trunk: include/llvm/Target/TargetAsmInfo.h lib/CodeGen/AsmPrinter/AsmPrinter.cpp lib/Target/ARM/ARMTargetAsmInfo.cpp lib/Target/PowerPC/PPCTargetAsmInfo.cpp lib/Target/TargetAsmInfo.cpp lib/Target/X86/X86TargetAsmInfo.cpp
Chris Lattner
clattner at apple.com
Sun Sep 21 11:58:23 PDT 2008
On Sep 21, 2008, at 11:56 AM, Chris Lattner wrote:
>> ++ llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp Mon Sep 8
>> 20:21:22 2008
>> @@ -462,7 +464,17 @@
>>
>> for (unsigned i = 0, e = InitList->getNumOperands(); i != e; ++i) {
>> const GlobalValue *GV = findGlobalValue(InitList->getOperand(i));
>> - if (GV && (!GV->hasInternalLinkage() || isa<Function>(GV))) {
>> + if (GV) {
>> + if (GV->hasInternalLinkage() && !isa<Function>(GV) &&
>> + ((strlen(TAI->getPrivateGlobalPrefix()) != 0 &&
>> + Mang->getValueName(GV)
>> + .substr(0,strlen(TAI->getPrivateGlobalPrefix())) ==
>> + TAI->getPrivateGlobalPrefix()) ||
>> + (strlen(TAI->getLessPrivateGlobalPrefix()) != 0 &&
>> + Mang->getValueName(GV)
>> + .substr(0,strlen(TAI->getLessPrivateGlobalPrefix()))
>> ==
>> + TAI->getLessPrivateGlobalPrefix())))
>> + continue;
>
> Please add a big fat comment above this if, explaining what it is
> doing and maybe even including an example. Thanks,
Oh, I see the code changed afterward, nevermind!
-Chris
More information about the llvm-commits
mailing list