[llvm-commits] llvm bitcode change for review or commit

Preston Gurd pgurd at rapidmind.com
Mon Sep 15 12:25:31 PDT 2008


Re-enables the new vector select in the bitcode reader, by modifying the
bitcode reader/writer as follows:

- add and use new bitcode FUNC_CODE_INST_VSELECT to handle the llvm
select opcode using either i1 or [N x i1] as the selector.
- retain old BITCODE FUNC_CODE_INST_SDELECT in the bitcode reader to
handle select on i1 for backwards compatibility with existing bitcode
files.
- re-enable the vector-select.ll test program.

Also, rename the recently added bitcode opcode FUNC_CODE_INST_VCMP to
FUNC_CODE_INST_CMP2 and make the bitcode writer use it to handle
fcmp/icmp on scalars or vectors. In the bitcode writer, use
FUNC_CODE_INST_CMP for vfcmp/vicmp only. In the bitcode reader, have
FUNC_CODE_INST_CMP handle icmp/fcmp returning bool, for backwards
compatibility with existing bitcode files.

Could someone please review these changes and either advise me what
additional changes you might want or else commit the patch for me?

Thanks,

Preston Gurd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm.diff
Type: text/x-patch
Size: 5474 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20080915/94e10c2f/attachment.bin>


More information about the llvm-commits mailing list