[llvm-commits] [llvm] r56194 - in /llvm/trunk: include/llvm/CodeGen/MachineOperand.h lib/CodeGen/MachineInstr.cpp

[Dale Johannesen]

Author: johannes
Date: Sat Sep 13 20:44:36 2008
New Revision: 56194

URL: http://llvm.org/viewvc/llvm-project?rev=56194&view=rev
Log:
adjust last patch per review feedback


Modified:
    llvm/trunk/include/llvm/CodeGen/MachineOperand.h
    llvm/trunk/lib/CodeGen/MachineInstr.cpp

Modified: llvm/trunk/include/llvm/CodeGen/MachineOperand.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/MachineOperand.h?rev=56194&r1=56193&r2=56194&view=diff

==============================================================================
--- llvm/trunk/include/llvm/CodeGen/MachineOperand.h (original)
+++ llvm/trunk/include/llvm/CodeGen/MachineOperand.h Sat Sep 13 20:44:36 2008
@@ -68,11 +68,9 @@
   /// This is only valid on definitions of registers.
   bool IsDead : 1;
 
-  /// IsEarlyClobber flag - this is only valid for MO_Register operands in
-  /// an inline asm.
-
-  /// IsEarlyClobber - True if this operand is marked earlyclobber in an
-  /// inline asm.  See gcc doc for description of earlyclobber.
+  /// IsEarlyClobber - True if this MO_Register operand is marked earlyclobber
+  /// in an inline asm.  Flag is not valid for any other case.   See gcc doc
+  /// for description of earlyclobber.
   bool IsEarlyClobber : 1;
 
   /// SubReg - Subregister number, only valid for MO_Register.  A value of 0
@@ -318,8 +316,7 @@
   /// the specified value.  If an operand is known to be an register already,
   /// the setReg method should be used.
   void ChangeToRegister(unsigned Reg, bool isDef, bool isImp = false,
-                        bool isKill = false, bool isDead = false,
-                        bool isEarlyClobber = false);
+                        bool isKill = false, bool isDead = false);
   
   //===--------------------------------------------------------------------===//
   // Construction methods.

Modified: llvm/trunk/lib/CodeGen/MachineInstr.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineInstr.cpp?rev=56194&r1=56193&r2=56194&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/MachineInstr.cpp (original)
+++ llvm/trunk/lib/CodeGen/MachineInstr.cpp Sat Sep 13 20:44:36 2008
@@ -104,11 +104,11 @@
 /// the specified value.  If an operand is known to be an register already,
 /// the setReg method should be used.
 void MachineOperand::ChangeToRegister(unsigned Reg, bool isDef, bool isImp,
-                                      bool isKill, bool isDead,
-                                      bool isEarlyClobber) {
+                                      bool isKill, bool isDead) {
   // If this operand is already a register operand, use setReg to update the 
   // register's use/def lists.
   if (isRegister()) {
+    assert(!isEarlyClobber());
     setReg(Reg);
   } else {
     // Otherwise, change this to a register and set the reg#.
@@ -127,7 +127,7 @@
   IsImp = isImp;
   IsKill = isKill;
   IsDead = isDead;
-  IsEarlyClobber = isEarlyClobber;
+  IsEarlyClobber = false;
   SubReg = 0;
 }