[llvm-commits] LLVM IR change for review or committal - resubmitted
Dan Gohman
gohman at apple.com
Mon Sep 8 11:35:21 PDT 2008
Hi Preston,
This looks good to me.
The FUNC_CODE_INST_VCMP thing is a little counter-intuitive. I guess
it's necessary in order to remain compatible with exiting vector
FUNC_CODE_INST_CMP usage though, right?
Thanks!
Dan
On Sep 8, 2008, at 8:10 AM, Preston Gurd wrote:
> Resubmitted without auto-generated stuff, as requested...
>
> This proposed change is intended to accomplish the following:
>
> - extend the vcmp/fcmp LLVM IR instructions to take vectors as
> arguments
> and, if so, to return a vector of boolean as a result;
>
> - extend the select LLVM IR instruction to allow you to specify a
> result
> type which is a vector of boolean, in which case the result will be an
> element-wise selection instead of choosing one vector or the other;
> and
>
> - updated LangRef.html to describe these changes.
>
> Could someone please review these changes and either advise me what
> additional changes you might want or else commit the patch for me?
>
> Thanks,
>
> Preston Gurd
>
>
> On Mon, 2008-08-09 at 04:19 -0400, Anton Korobeynikov wrote:
>> Hello, Preston
>>
>>> Could someone please review these changes and either advise me what
>>> additional changes you might want or else commit the patch for me?
>> Please remove auto-generated stuff from patch, this simplifies
>> review greatly.
>>
>> --
>> With best regards, Anton Korobeynikov
>> Faculty of Mathematics and Mechanics, Saint Petersburg State
>> University
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> <llvm.diff>
More information about the llvm-commits
mailing list