[llvm-commits] [patch] add bound checks to SmallVector

[Evan Cheng]

On Sep 5, 2008, at 4:27 AM, Rafael Espindola wrote:

> 2008/8/28 Dan Gohman <gohman at apple.com>:
>> Hi Rafael,
>>
>> I suspect it's not too expensive for a debug build, but it would
>> be nice if you could run a few experiments to verify this. If it
>> does end up being significant, it would still be appropriate to
>> add to ENABLE_EXPENSIVE_CHECKS=1 builds at least.
>
> I did a "make check" 3 times with and without the patch. The results
> with the patch were 55.598s, 49.925s and 50.069s. Without the patch
> the results were 49.808s, 50.162s and 49.860s.
>
> Is "make check" a reasonable test? OK to commit the patch?

Probably not sufficient. Can you try it on kimwitu++? We are  
interested in llc time.

Thanks,

Evan

>
>
>> Dan
>
> Cheers,
> -- 
> Rafael Avila de Espindola
>
> Google | Gordon House | Barrow Street | Dublin 4 | Ireland
> Registered in Dublin, Ireland | Registration Number: 368047
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits