[llvm-commits] [llvm] r55457 - in /llvm/trunk: include/llvm/CodeGen/SelectionDAGNodes.h include/llvm/Target/TargetLowering.h lib/CodeGen/SelectionDAG/LegalizeDAG.cpp lib/CodeGen/SelectionDAG/SelectionDAG.cpp lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp lib/Target/TargetSelectionDAG.td lib/Target/X86/X86ISelLowering.cpp lib/Target/X86/X86Instr64bit.td lib/Target/X86/X86InstrInfo.td

[Duncan Sands]

> MemSDNode has a MemoryVT member. This is used for truncating
> stores and extending loads to indicate the type of the actual
> memory access. We don't have extending or truncating atomics,
> so I believe it's redundant in AtomicSDNode.

On the other hand, having ATOMIC_LOAD_ADD that acts on an i8
seems quite analogous to an extending load to me.  So rather
than introducing new names ATOMIC_LOAD_ADD_{8,16,32,64}, how
about using MemoryVT to indicate the size of the partial word
being acted on (i.e. i8, i16, i32, i64) instead?

Ciao,

Duncan.