[llvm-commits] [llvm] r55293 - in /llvm/trunk: include/llvm/CodeGen/PseudoSourceValue.h lib/CodeGen/MachineInstr.cpp lib/CodeGen/PseudoSourceValue.cpp

Chris Lattner sabre at nondot.org
Sun Aug 24 13:37:33 PDT 2008


Author: lattner
Date: Sun Aug 24 15:37:32 2008
New Revision: 55293

URL: http://llvm.org/viewvc/llvm-project?rev=55293&view=rev
Log:
simplify PseudoSourceValue printing a bit.  Unnest all of PseudoSourceValue.cpp from the llvm namespace.

Modified:
    llvm/trunk/include/llvm/CodeGen/PseudoSourceValue.h
    llvm/trunk/lib/CodeGen/MachineInstr.cpp
    llvm/trunk/lib/CodeGen/PseudoSourceValue.cpp

Modified: llvm/trunk/include/llvm/CodeGen/PseudoSourceValue.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/PseudoSourceValue.h?rev=55293&r1=55292&r2=55293&view=diff

==============================================================================
--- llvm/trunk/include/llvm/CodeGen/PseudoSourceValue.h (original)
+++ llvm/trunk/include/llvm/CodeGen/PseudoSourceValue.h Sun Aug 24 15:37:32 2008
@@ -28,8 +28,7 @@
   public:
     PseudoSourceValue();
 
-    virtual void print(std::ostream &OS) const;
-    virtual void print(raw_ostream &OS) const;
+    void print(raw_ostream &OS) const;
 
     /// isConstant - Test whether this PseudoSourceValue has a constant value.
     ///
@@ -61,16 +60,6 @@
     /// A SV referencing the jump table
     static const PseudoSourceValue *getJumpTable();
   };
-
-inline std::ostream &operator<<(std::ostream &OS,const PseudoSourceValue &PSV) {
-  PSV.print(OS);
-  return OS;
-}
-inline raw_ostream &operator<<(raw_ostream &OS, const PseudoSourceValue &PSV) {
-  PSV.print(OS);
-  return OS;
-}
-
 } // End llvm namespace
 
 #endif

Modified: llvm/trunk/lib/CodeGen/MachineInstr.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineInstr.cpp?rev=55293&r1=55292&r2=55293&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/MachineInstr.cpp (original)
+++ llvm/trunk/lib/CodeGen/MachineInstr.cpp Sun Aug 24 15:37:32 2008
@@ -24,6 +24,7 @@
 #include "llvm/Support/LeakDetector.h"
 #include "llvm/Support/MathExtras.h"
 #include "llvm/Support/Streams.h"
+#include "llvm/Support/raw_ostream.h"
 #include "llvm/ADT/FoldingSet.h"
 #include <ostream>
 using namespace llvm;
@@ -756,9 +757,10 @@
         OS << "<unknown>";
       else if (!V->getName().empty())
         OS << V->getName();
-      else if (const PseudoSourceValue *PSV = dyn_cast<PseudoSourceValue>(V))
-        OS << *PSV;
-      else
+      else if (const PseudoSourceValue *PSV = dyn_cast<PseudoSourceValue>(V)) {
+        raw_os_ostream OSS(OS);
+        PSV->print(OSS);
+      } else
         OS << V;
 
       OS << " + " << MRO.getOffset() << "]";

Modified: llvm/trunk/lib/CodeGen/PseudoSourceValue.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/PseudoSourceValue.cpp?rev=55293&r1=55292&r2=55293&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/PseudoSourceValue.cpp (original)
+++ llvm/trunk/lib/CodeGen/PseudoSourceValue.cpp Sun Aug 24 15:37:32 2008
@@ -18,36 +18,34 @@
 #include "llvm/Support/ManagedStatic.h"
 #include "llvm/Support/raw_ostream.h"
 #include <map>
+using namespace llvm;
 
-namespace llvm {
-  static ManagedStatic<PseudoSourceValue[4]> PSVs;
+static ManagedStatic<PseudoSourceValue[4]> PSVs;
 
-  const PseudoSourceValue *PseudoSourceValue::getStack()
-  { return &(*PSVs)[0]; }
-  const PseudoSourceValue *PseudoSourceValue::getGOT()
-  { return &(*PSVs)[1]; }
-  const PseudoSourceValue *PseudoSourceValue::getJumpTable()
-  { return &(*PSVs)[2]; }
-  const PseudoSourceValue *PseudoSourceValue::getConstantPool()
-  { return &(*PSVs)[3]; }
-
-  static const char *const PSVNames[] = {
-    "Stack",
-    "GOT",
-    "JumpTable",
-    "ConstantPool"
-  };
+const PseudoSourceValue *PseudoSourceValue::getStack()
+{ return &(*PSVs)[0]; }
+const PseudoSourceValue *PseudoSourceValue::getGOT()
+{ return &(*PSVs)[1]; }
+const PseudoSourceValue *PseudoSourceValue::getJumpTable()
+{ return &(*PSVs)[2]; }
+const PseudoSourceValue *PseudoSourceValue::getConstantPool()
+{ return &(*PSVs)[3]; }
+
+static const char *const PSVNames[] = {
+  "Stack",
+  "GOT",
+  "JumpTable",
+  "ConstantPool"
+};
 
-  PseudoSourceValue::PseudoSourceValue() :
-    Value(PointerType::getUnqual(Type::Int8Ty), PseudoSourceValueVal) {}
+PseudoSourceValue::PseudoSourceValue() :
+  Value(PointerType::getUnqual(Type::Int8Ty), PseudoSourceValueVal) {}
 
-  void PseudoSourceValue::print(std::ostream &OS) const {
-    OS << PSVNames[this - *PSVs];
-  }
-  void PseudoSourceValue::print(raw_ostream &OS) const {
-    OS << PSVNames[this - *PSVs];
-  }
+void PseudoSourceValue::print(raw_ostream &OS) const {
+  OS << PSVNames[this - *PSVs];
+}
 
+namespace {
   /// FixedStackPseudoSourceValue - A specialized PseudoSourceValue
   /// for holding FixedStack values, which must include a frame
   /// index.
@@ -66,29 +64,28 @@
       OS << "FixedStack" << FI;
     }
   };
+}
 
-  static ManagedStatic<std::map<int, const PseudoSourceValue *> > FSValues;
+static ManagedStatic<std::map<int, const PseudoSourceValue *> > FSValues;
 
-  const PseudoSourceValue *PseudoSourceValue::getFixedStack(int FI) {
-    const PseudoSourceValue *&V = (*FSValues)[FI];
-    if (!V)
-      V = new FixedStackPseudoSourceValue(FI);
-    return V;
-  }
-
-  bool PseudoSourceValue::isConstant(const MachineFrameInfo *) const {
-    if (this == getStack())
-      return false;
-    if (this == getGOT() ||
-        this == getConstantPool() ||
-        this == getJumpTable())
-      return true;
-    assert(0 && "Unknown PseudoSourceValue!");
+const PseudoSourceValue *PseudoSourceValue::getFixedStack(int FI) {
+  const PseudoSourceValue *&V = (*FSValues)[FI];
+  if (!V)
+    V = new FixedStackPseudoSourceValue(FI);
+  return V;
+}
+
+bool PseudoSourceValue::isConstant(const MachineFrameInfo *) const {
+  if (this == getStack())
     return false;
-  }
+  if (this == getGOT() ||
+      this == getConstantPool() ||
+      this == getJumpTable())
+    return true;
+  assert(0 && "Unknown PseudoSourceValue!");
+  return false;
+}
 
-  bool
-  FixedStackPseudoSourceValue::isConstant(const MachineFrameInfo *MFI) const {
-    return MFI && MFI->isImmutableObjectIndex(FI);
-  }
+bool FixedStackPseudoSourceValue::isConstant(const MachineFrameInfo *MFI) const{
+  return MFI && MFI->isImmutableObjectIndex(FI);
 }





More information about the llvm-commits mailing list