[llvm-commits] [llvm] r55210 - in /llvm/trunk: include/llvm/ADT/FoldingSet.h lib/Support/FoldingSet.cpp

Chris Lattner clattner at apple.com
Fri Aug 22 20:18:03 PDT 2008


On Aug 22, 2008, at 7:12 PM, Dan Gohman wrote:
>> Hrm, I was pretty sure it did own the nodes, who else would?   
>> However,
>> the dtor isn't freeing them.  Are they all getting leaked?  What am I
>> forgetting here?
>
> Are you thinking of ilist? It does own its nodes, though there's a
> way to remove them and reclaim ownership, and SelectionDAG uses it,
> for example. SelectionDAG takes care of deaellocation of its nodes.

I was pretty certain that foldingset owned all its nodes.  Should it  
assert that it is empty on destruction?

-Chris



More information about the llvm-commits mailing list