[llvm-commits] [patch] fix PR 2682

Chris Lattner clattner at apple.com
Fri Aug 22 08:46:54 PDT 2008


On Aug 22, 2008, at 6:48 AM, Rafael Espindola wrote:

> The attached patch fixes 2682. I am sending it for review before
> committing because it is mostly a hack.
>
> GCC uses optimization information to emit warnings. In this particular
> case, it assumes that by the time __builtin_prefetch is expanded,
> __builtin_constant_p will have been folded.
>
> This is not the case in llvm-gcc, since pass_fold_builtins is
> disabled. This patch enables just the __builtin_constant_p case in it.
> OK for trunk? I was not able to test with a full bootstrap since
> llvm-gcc bootstrap is broken on linux x86-64 at 55175.

Looks great to me, please commit!  Thanks Rafael,

-Chris



More information about the llvm-commits mailing list