[llvm-commits] [llvm] r55016 - /llvm/trunk/test/CodeGen/X86/fast-isel.ll

[Dan Gohman]

On Aug 19, 2008, at 5:38 PM, Chris Lattner wrote:

> On Aug 19, 2008, at 3:37 PM, Dan Gohman wrote:
>> URL: http://llvm.org/viewvc/llvm-project?rev=55016&view=rev
>> Log:
>> Fast-isel is now *minimally* functional. Add a testcase to
>> demonstrate the extent of its capabilities. Note that it
>> only attempts to operate on one of the blocks in this
>> testcase.
>
> Woo hoo.  Please add -march=x86 to the run line though.

Ok.

>
>
> Also, in:
>
> +    if (FastISel *F = TLI.createFastISel(BB, &FuncInfo.MF,
> +
> TLI.getTargetMachine().getInstrInfo())) {
> +      BasicBlock::iterator I =
> +        F->SelectInstructions(LLVMBB->begin(), LLVMBB->end(),
> FuncInfo.ValueMap);
> +      if (I == LLVMBB->end())
> +        // The "fast" selector selected the entire block, so we're
> done.
> +        return;
> +
> +      // The "fast" selector couldn't handle something and bailed.
> +      // For the temporary purpose of debugging, just abort.
> +      I->dump();
> +      assert(0 && "FastISel didn't select the entire block");
> +      abort();
> +    }
>
> it looks like you're leaking F.

Ok.

Dan