[llvm-commits] [llvm] r54744 - in /llvm/trunk/lib: AsmParser/LLLexer.cpp AsmParser/llvmAsmParser.y VMCore/AsmWriter.cpp VMCore/Verifier.cpp

[Dale Johannesen]

On Aug 13, 2008, at 1:10 PMPDT, Anton Korobeynikov wrote:

> Hi, Dale
>
>> Add read/write support for X86's sseregparm.
> Why don't use inreg attribute for this? It seems, you don't need new  
> CC for sseregparm.

It does that for parameters (already did); the issue is return values.
(And it's not new, it was there, just not fully implemented.  See  
X86CallingConv.td.)

>
>
> +               (TARGET_SSEREGPARM ||                            \
> +                lookup_attribute("sseregparm",                  \
> +                                 type_attributes))){            \
>
> What's about check for TARGET_SSE_MATH also?


Yeah, thanks, that should be checked somewhere, let me look.