[llvm-commits] [llvm] r54640 - in /llvm/trunk/include/llvm/Support: ConstantFolder.h IRBuilder.h TargetFolder.h

[Duncan Sands]

Hi Chris,

> Very nice Duncan, this is something we've needed for quite awhile.   
> This also gives us the ability to have an IRBuilder that does no  
> constant folding.  With a folder that just returns the instructions.

yes, one of the advantages of using a template parameter is that
you can do this.  I may add a NullBuilder tonight if I'm feeling
generous :)

...
> Because of the name of this file, I expect a lot of people to go here  
> to look for the LLVM IR constant folding interfaces.  Please document  
> that this file is designed for use with IRBuilder and point people to  
> the ConstantExpr::get* methods and libanalysis for simple constant  
> folding uses.
...
> Likewise, please say that this is for use with IRBuilder.

Done.

> > +  Constant *CreateCompare(CmpInst::Predicate P, Constant *LHS,  
> > Constant *RHS) const {
> 
> 80 columns?

Sorry about that: it must have happened when I appended "const"
everywhere.  Fixed.

Ciao,

Duncan.