[llvm-commits] DebugInfoBuilder

Talin viridia at gmail.com
Mon Aug 11 14:14:09 PDT 2008


OK I cleaned up the > 80 lines and renamed the methods as suggested.
With regards to the LLVMDebugVersion constants - I merely copied those from
MachineModuleInfo, I have no idea what the various version numbers
correspond to.

The problem with the debug version constants is that they are buried inside
of the CodeGen module, and I didn't want to create a dependency from the
Support module to the CodeGen module. Ideally, those constants should be
relocated to some header file where both CodeGen and Support can access
them. However, I don't know where that would be. So in the mean time I've
merely copied the definitions until a decision is made.

On the issue of ConstantStruct::get() and SmallVector: The way I tend to
design APIs is to take either a begin/end iterator or a begin/end pointer.
That allows you to use either a regular vector or a SmallVector with the
same API call. (Pointers are probably more correct, although I have noticed
that gcc lets you intermix pointers from differently-sized SmallVectors
without complaint.)

-- 
-- Talin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20080811/0e87c165/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIB.patch
Type: application/octet-stream
Size: 18043 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20080811/0e87c165/attachment.obj>


More information about the llvm-commits mailing list