[llvm-commits] [llvm] r54517 - in /llvm/trunk: lib/CodeGen/AsmPrinter.cpp test/CodeGen/Generic/2008-08-07-PtrToInt-SmallerInt.ll

[Nick Lewycky]

Author: nicholas
Date: Fri Aug  8 01:34:07 2008
New Revision: 54517

URL: http://llvm.org/viewvc/llvm-project?rev=54517&view=rev
Log:
Don't crash printing the asm for a ConstantExpr PtrToInt just because the int
is narrower than the pointer. This testcase emits:

  .byte (((17) - 16) & 255)


Added:
    llvm/trunk/test/CodeGen/Generic/2008-08-07-PtrToInt-SmallerInt.ll
Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter.cpp

Modified: llvm/trunk/lib/CodeGen/AsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter.cpp?rev=54517&r1=54516&r2=54517&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter.cpp Fri Aug  8 01:34:07 2008
@@ -821,12 +821,13 @@
 
       // We can emit the pointer value into this slot if the slot is an
       // integer slot greater or equal to the size of the pointer.
-      if (Ty->isInteger() &&
-          TD->getABITypeSize(Ty) >= TD->getABITypeSize(Op->getType()))
+      if (TD->getABITypeSize(Ty) >= TD->getABITypeSize(Op->getType()))
         return EmitConstantValueOnly(Op);
-      
-      assert(0 && "FIXME: Don't yet support this kind of constant cast expr");
+
+      O << "((";
       EmitConstantValueOnly(Op);
+      APInt ptrMask = APInt::getAllOnesValue(TD->getABITypeSizeInBits(Ty));
+      O << ") & " << ptrMask.toStringUnsigned() << ')';
       break;
     }
     case Instruction::Add:

Added: llvm/trunk/test/CodeGen/Generic/2008-08-07-PtrToInt-SmallerInt.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Generic/2008-08-07-PtrToInt-SmallerInt.ll?rev=54517&view=auto

==============================================================================
--- llvm/trunk/test/CodeGen/Generic/2008-08-07-PtrToInt-SmallerInt.ll (added)
+++ llvm/trunk/test/CodeGen/Generic/2008-08-07-PtrToInt-SmallerInt.ll Fri Aug  8 01:34:07 2008
@@ -0,0 +1,7 @@
+; RUN: llvm-as < %s | llc
+; PR2603
+target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:32:32"
+target triple = "i386-pc-linux-gnu"
+        %struct.A = type { i8 }
+        %struct.B = type { i8, [1 x i8] }
+ at Foo = constant %struct.A { i8 ptrtoint (i8* getelementptr ([1 x i8]* inttoptr (i32 17 to [1 x i8]*), i32 0, i32 -16) to i8) }          ; <%struct.A*> [#uses=0]