[llvm-commits] SoftenFloatOp support for fp_round

[Duncan Sands]

Hi Bruno,

> Done. The new patch contain the changes.

+  unsigned Size = NVT.getSizeInBits();
+
+  // Mask = ~(1 << SizeInBits)

The comment should say ~(1 << (Size-1))

+  SDValue Mask = DAG.getConstant(APInt::getMaxValue(Size).clear(Size-1), NVT);

I think it's clearer to use getAllOnesValue rather than getMaxValue.

+  SDValue Lo = GetSoftenedFloat(N->getOperand(0));

Not sure why this is called "Lo".  How about Op?

> Ok to commit?

Yes, with the above tweaks.

Thanks for doing this,

Duncan.