[llvm-commits] [llvm] r54334 - in /llvm/trunk/test/CodeGen: ARM/2007-08-15-ReuseBug.ll ARM/remat.ll X86/2007-07-25-EpilogueBug.ll X86/2007-11-14-Coalescer-Bug.ll X86/2007-11-30-LoadFolding-Bug.ll X86/2007-11-30-TestLoadFolding.ll X86/2008-04-17-CoalescerBug.ll X86/2008-05-06-SpillerBug.ll X86/2008-05-21-CoalescerBug.ll X86/2008-06-13-SpillerCommuting.ll X86/ins_subreg_coalesce-3.ll

[Chris Lattner]

On Aug 5, 2008, at 10:53 AM, Evan Cheng wrote:
> On Aug 5, 2008, at 9:31 AM, Chris Lattner wrote:
>> On Aug 5, 2008, at 12:27 AM, Evan Cheng wrote:
>>> I believe there are 11 test cases that cannot be trivially fixed. I
>>> am
>>> not sure how easy it is to go back and re-reduce these tests? That
>>> can
>>> take a lot of time.
>>
>> Which tests?  What are they doing?  Why not just add non-dead edges
>> (e.g. new bool arguments to the function or load of a bool for branch
>> conditions) in the CFG to prevent the blocks from being deleted?
>
> You do realize that's not always possible? Any tests that are
> dependent on behavior of register allocator / spiller / coalescer are
> very fragile as it is.

Do you intend to add a new option every time a change to codegen  
potentially perturbs one of these tests?  They should be updated or  
removed if they are too fragile.  Changing the RUN line of a test is  
perfectly acceptable.

> That's fine. Just realize some tests will not end up testing the same
> thing and some may end up being removed.

Understood, thanks

-Chris