[llvm-commits] [llvm] r54334 - in /llvm/trunk/test/CodeGen: ARM/2007-08-15-ReuseBug.ll ARM/remat.ll X86/2007-07-25-EpilogueBug.ll X86/2007-11-14-Coalescer-Bug.ll X86/2007-11-30-LoadFolding-Bug.ll X86/2007-11-30-TestLoadFolding.ll X86/2008-04-17-CoalescerBug.ll X86/2008-05-06-SpillerBug.ll X86/2008-05-21-CoalescerBug.ll X86/2008-06-13-SpillerCommuting.ll X86/ins_subreg_coalesce-3.ll

[Chris Lattner]

On Aug 5, 2008, at 12:27 AM, Evan Cheng wrote:

> I believe there are 11 test cases that cannot be trivially fixed. I am
> not sure how easy it is to go back and re-reduce these tests? That can
> take a lot of time.

Which tests?  What are they doing?  Why not just add non-dead edges  
(e.g. new bool arguments to the function or load of a bool for branch  
conditions) in the CFG to prevent the blocks from being deleted?

> It's likely some of the tests will require more effort to fix up /
> regen than it's worth. If you are totally against the option, we can
> simply remove those tests that are now invalid.

Fixing 11 tests is cheaper than carrying around a dead option  
*forever*.  Why is updating the tests hard?  I'm not suggesting you  
find the original source of the test and update them, just tweak the  
test to test the right thing.

-Chris