[llvm-commits] [llvm] r54334 - in /llvm/trunk/test/CodeGen: ARM/2007-08-15-ReuseBug.ll ARM/remat.ll X86/2007-07-25-EpilogueBug.ll X86/2007-11-14-Coalescer-Bug.ll X86/2007-11-30-LoadFolding-Bug.ll X86/2007-11-30-TestLoadFolding.ll X86/2008-04-17-CoalescerBug.ll X86/2008-05-06-SpillerBug.ll X86/2008-05-21-CoalescerBug.ll X86/2008-06-13-SpillerCommuting.ll X86/ins_subreg_coalesce-3.ll

[Chris Lattner]

On Aug 4, 2008, at 10:26 PM, Evan Cheng wrote:

> My understanding is Owen made an effort to fix the tests but he wasn't
> successful in most cases. I suggested an option instead.

I'd strongly prefer to avoid options that are only useful for  
testcases.  The testcases should be fixed, this just indicates that  
they were "overreduced" when created.

-Chris

>
>
> Evan
>
> On Aug 4, 2008, at 6:25 PM, Chris Lattner <clattner at apple.com> wrote:
>
>>
>> On Aug 4, 2008, at 4:55 PM, Owen Anderson wrote:
>>
>>> Author: resistor
>>> Date: Mon Aug  4 18:55:29 2008
>>> New Revision: 54334
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=54334&view=rev
>>> Log:
>>> Update these tests to work by disabling the new correct CFG
>>> generation.  This flag should ONLY be used to for tests like these.
>>
>> Why not modify the tests so that they don't have dead blocks?
>>
>> -Chris
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits