[llvm-commits] [llvm] r54158 - /llvm/trunk/tools/bugpoint/CrashDebugger.cpp

[Nick Lewycky]

Matthijs Kooijman wrote:
> Author: matthijs
> Date: Tue Jul 29 03:55:30 2008
> New Revision: 54158
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=54158&view=rev
> Log:
> Improve bugpoint output a bit by outputting the actual instructions instead of
> just it's name, which is often empty. Also remove a newline from the output
> that wasn't really needed.

I'm not sure that's such a good idea.

I've certainly had cases where the mere attempt to print an instruction 
would cause it to eat up enormous amounts of memory and crash. The 
problem is enormous Types, in case anyone is wondering, and yes the code 
compiles fine otherwise.

Nick

> Modified:
>     llvm/trunk/tools/bugpoint/CrashDebugger.cpp
> 
> Modified: llvm/trunk/tools/bugpoint/CrashDebugger.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/bugpoint/CrashDebugger.cpp?rev=54158&r1=54157&r2=54158&view=diff
> 
> ==============================================================================
> --- llvm/trunk/tools/bugpoint/CrashDebugger.cpp (original)
> +++ llvm/trunk/tools/bugpoint/CrashDebugger.cpp Tue Jul 29 03:55:30 2008
> @@ -469,7 +469,7 @@
>              } else {
>                if (BugpointIsInterrupted) goto ExitLoops;
>  
> -              std::cout << "Checking instruction '" << I->getName() << "': ";
> +              std::cout << "Checking instruction: " << *I;
>                Module *M = BD.deleteInstructionFromProgram(I, Simplification);
>  
>                // Find out if the pass still crashes on this pass...
> @@ -539,7 +539,6 @@
>  
>  static bool TestForCodeGenCrash(BugDriver &BD, Module *M) {
>    try {
> -    std::cerr << '\n';
>      BD.compileProgram(M);
>      std::cerr << '\n';
>      return false;
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>