[llvm-commits] [llvm] r53908 - in /llvm/trunk/lib/Target/Mips: MipsISelLowering.cpp MipsTargetAsmInfo.cpp MipsTargetAsmInfo.h

[Bruno Cardoso Lopes]

Author: bruno
Date: Tue Jul 22 10:34:27 2008
New Revision: 53908

URL: http://llvm.org/viewvc/llvm-project?rev=53908&view=rev
Log:
Added small section asm emition logic for mips.
Fixed small bug.

Modified:
    llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp
    llvm/trunk/lib/Target/Mips/MipsTargetAsmInfo.cpp
    llvm/trunk/lib/Target/Mips/MipsTargetAsmInfo.h

Modified: llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp?rev=53908&r1=53907&r2=53908&view=diff

==============================================================================
--- llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp Tue Jul 22 10:34:27 2008
@@ -241,10 +241,11 @@
 bool MipsTargetLowering::IsGlobalInSmallSection(GlobalValue *GV)
 {
   const TargetData *TD = getTargetData();
-  const Value *V = dyn_cast<Value>(GV);
-  const GlobalVariable *GVA = dyn_cast<GlobalVariable>(V);
+  const GlobalVariable *GVA = dyn_cast<GlobalVariable>(GV);
+
+  if (!GVA)
+    return false;
   
-  //const PointerType *PTy = GV->getType();
   const Type *Ty = GV->getType()->getElementType();
   unsigned Size = TD->getABITypeSize(Ty);
 

Modified: llvm/trunk/lib/Target/Mips/MipsTargetAsmInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsTargetAsmInfo.cpp?rev=53908&r1=53907&r2=53908&view=diff

==============================================================================
--- llvm/trunk/lib/Target/Mips/MipsTargetAsmInfo.cpp (original)
+++ llvm/trunk/lib/Target/Mips/MipsTargetAsmInfo.cpp Tue Jul 22 10:34:27 2008
@@ -19,6 +19,8 @@
 MipsTargetAsmInfo::MipsTargetAsmInfo(const MipsTargetMachine &TM):
   ELFTargetAsmInfo(TM) {
 
+  MipsTM = &TM;
+
   AlignmentIsInBytes          = false;
   COMMDirectiveTakesAlignment = true;
   Data16bitsDirective         = "\t.half\t";
@@ -37,5 +39,66 @@
     JumpTableDirective = "\t.word\t";
   else
     JumpTableDirective = "\t.gpword\t";
+  
+  SmallDataSection = getNamedSection("\t.sdata", SectionFlags::Writeable);
+  SmallBSSSection  = getNamedSection("\t.sbss",
+                         SectionFlags::Writeable | SectionFlags::BSS);
+}
+
+static bool isSuitableForBSS(const GlobalVariable *GV) {
+  if (!GV->hasInitializer())
+    return true;
+
+  // Leave constant zeros in readonly constant sections, so they can be shared
+  Constant *C = GV->getInitializer();
+  return (C->isNullValue() && !GV->isConstant() && !NoZerosInBSS);
+}
+
+SectionKind::Kind
+MipsTargetAsmInfo::SectionKindForGlobal(const GlobalValue *GV) const {
+  const TargetData *TD = ETM->getTargetData();
+  const GlobalVariable *GVA = dyn_cast<GlobalVariable>(GV);
+
+  if (!GVA)
+    return ELFTargetAsmInfo::SectionKindForGlobal(GV);
+  
+  // if this is a internal constant string, there is a special
+  // section for it, but not in small data/bss.
+  if (GVA->hasInitializer() && GV->hasInternalLinkage()) {
+    Constant *C = GVA->getInitializer();
+    const ConstantArray *CVA = dyn_cast<ConstantArray>(C);
+    if (CVA && CVA->isCString()) 
+      return ELFTargetAsmInfo::SectionKindForGlobal(GV);
+  }
+
+  const Type *Ty = GV->getType()->getElementType();
+  unsigned Size = TD->getABITypeSize(Ty);
+  unsigned Threshold = 
+    MipsTM->getSubtarget<MipsSubtarget>().getSSectionThreshold();
+
+  if (Size > 0 && Size <= Threshold) {
+    if (isSuitableForBSS(GVA))
+      return SectionKind::SmallBSS;
+    else
+      return SectionKind::SmallData;
+  }
+
+  return ELFTargetAsmInfo::SectionKindForGlobal(GV);
+}
+
+const Section*
+MipsTargetAsmInfo::SelectSectionForGlobal(const GlobalValue *GV) const {
+  SectionKind::Kind K = SectionKindForGlobal(GV);
+  const GlobalVariable *GVA = dyn_cast<GlobalVariable>(GV);
+
+  if (GVA && (!GVA->isWeakForLinker()))
+    switch (K) {
+      case SectionKind::SmallData:
+        return getSmallDataSection();
+      case SectionKind::SmallBSS:
+        return getSmallBSSSection();
+      default: break;
+    }
 
+  return ELFTargetAsmInfo::SelectSectionForGlobal(GV);
 }

Modified: llvm/trunk/lib/Target/Mips/MipsTargetAsmInfo.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsTargetAsmInfo.h?rev=53908&r1=53907&r2=53908&view=diff

==============================================================================
--- llvm/trunk/lib/Target/Mips/MipsTargetAsmInfo.h (original)
+++ llvm/trunk/lib/Target/Mips/MipsTargetAsmInfo.h Tue Jul 22 10:34:27 2008
@@ -16,6 +16,9 @@
 
 #include "llvm/Target/TargetAsmInfo.h"
 #include "llvm/Target/ELFTargetAsmInfo.h"
+#include "llvm/DerivedTypes.h"
+#include "llvm/GlobalVariable.h"
+#include "llvm/Target/TargetOptions.h"
 
 namespace llvm {
 
@@ -24,6 +27,17 @@
 
   struct MipsTargetAsmInfo : public ELFTargetAsmInfo {
     explicit MipsTargetAsmInfo(const MipsTargetMachine &TM);
+
+    /// SectionKindForGlobal - This hook allows the target to select proper
+    /// section kind used for global emission.
+    virtual SectionKind::Kind
+    SectionKindForGlobal(const GlobalValue *GV) const;
+
+    virtual const Section* SelectSectionForGlobal(const GlobalValue *GV) const;
+
+    private:
+      const MipsTargetMachine *MipsTM; 
+
   };
 
 } // namespace llvm