[llvm-commits] [LLVMdev] atomic memoperand patch

Mon P Wang wangmp at apple.com
Wed Jul 16 21:51:16 PDT 2008


Hi,

Opps, I sent it the wrong list so I'm sending it back to commit.  I  
think the indentation in the code is fine but the subversion  
difference and the wrapping makes it look like we are missing a space.

Thanks,
   -- Mon Ping


On Jul 16, 2008, at 6:03 PM, Duncan Sands wrote:

> Hi,
>
>>    MIB.addReg(t2);
>> -
>> +  assert(bInstr->hasOneMemOperand() && "Unexpected number of
>> memoperand");
>> +  (*MIB).addMemOperand(*F, *bInstr->memoperands_begin());
>> +
>>    MIB = BuildMI(newMBB, TII->get(X86::MOV32rr), destOper.getReg());
>
> this doesn't seem to be indented right (needs one more space).
> Same for the rest of the patch.
>
> Ciao,
>
> Duncan.




More information about the llvm-commits mailing list