[llvm-commits] [llvm] r53309 - in /llvm/trunk/lib/Target: TargetAsmInfo.cpp X86/X86ATTAsmPrinter.cpp

Anton Korobeynikov asl at math.spbu.ru
Wed Jul 9 06:24:39 PDT 2008


Author: asl
Date: Wed Jul  9 08:24:38 2008
New Revision: 53309

URL: http://llvm.org/viewvc/llvm-project?rev=53309&view=rev
Log:
Fix thinko

Modified:
    llvm/trunk/lib/Target/TargetAsmInfo.cpp
    llvm/trunk/lib/Target/X86/X86ATTAsmPrinter.cpp

Modified: llvm/trunk/lib/Target/TargetAsmInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/TargetAsmInfo.cpp?rev=53309&r1=53308&r2=53309&view=diff

==============================================================================
--- llvm/trunk/lib/Target/TargetAsmInfo.cpp (original)
+++ llvm/trunk/lib/Target/TargetAsmInfo.cpp Wed Jul  9 08:24:38 2008
@@ -167,7 +167,6 @@
   bool isThreadLocal = GVar->isThreadLocal();
   assert(GVar && "Invalid global value for section selection");
 
-  SectionKind::Kind kind;
   if (isSuitableForBSS(GVar)) {
     // Variable can be easily put to BSS section.
     return (isThreadLocal ? SectionKind::ThreadBSS : SectionKind::BSS);
@@ -177,14 +176,14 @@
     // note, there is no thread-local r/o section.
     Constant *C = GVar->getInitializer();
     if (C->ContainsRelocations())
-      kind = SectionKind::ROData;
+      return SectionKind::ROData;
     else {
       const ConstantArray *CVA = dyn_cast<ConstantArray>(C);
       // Check, if initializer is a null-terminated string
       if (CVA && CVA->isCString())
-        kind = SectionKind::RODataMergeStr;
+        return SectionKind::RODataMergeStr;
       else
-        kind = SectionKind::RODataMergeConst;
+        return SectionKind::RODataMergeConst;
     }
   }
 

Modified: llvm/trunk/lib/Target/X86/X86ATTAsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ATTAsmPrinter.cpp?rev=53309&r1=53308&r2=53309&view=diff

==============================================================================
--- llvm/trunk/lib/Target/X86/X86ATTAsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ATTAsmPrinter.cpp Wed Jul  9 08:24:38 2008
@@ -32,6 +32,8 @@
 #include "llvm/Target/TargetOptions.h"
 using namespace llvm;
 
+#include <iostream>
+
 STATISTIC(EmittedInsts, "Number of machine instrs printed");
 
 static std::string getPICLabelString(unsigned FnNum,
@@ -772,6 +774,9 @@
   if (!GVar->hasInitializer())
     return;   // External global require no code
 
+  GVar->dump();
+  std::cout << TAI->SectionForGlobal(GVar) << std::endl;
+
   // Check to see if this is a special global used by LLVM, if so, emit it.
   if (EmitSpecialLLVMGlobal(GVar)) {
     if (Subtarget->isTargetDarwin() &&





More information about the llvm-commits mailing list