[llvm-commits] [llvm] r53228 - in /llvm/trunk: include/llvm/Function.h lib/VMCore/Function.cpp
Duncan Sands
baldrick at free.fr
Tue Jul 8 02:41:30 PDT 2008
Author: baldrick
Date: Tue Jul 8 04:41:30 2008
New Revision: 53228
URL: http://llvm.org/viewvc/llvm-project?rev=53228&view=rev
Log:
Add some helpers for manipulating function
parameter attributes.
Modified:
llvm/trunk/include/llvm/Function.h
llvm/trunk/lib/VMCore/Function.cpp
Modified: llvm/trunk/include/llvm/Function.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Function.h?rev=53228&r1=53227&r2=53228&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Function.h (original)
+++ llvm/trunk/include/llvm/Function.h Tue Jul 8 04:41:30 2008
@@ -174,29 +174,49 @@
/// addParamAttr - adds the attribute to the list of attributes.
void addParamAttr(unsigned i, ParameterAttributes attr);
+ /// removeParamAttr - removes the attribute from the list of attributes.
+ void removeParamAttr(unsigned i, ParameterAttributes attr);
+
/// @brief Extract the alignment for a call or parameter (0=unknown).
unsigned getParamAlignment(unsigned i) const {
return ParamAttrs.getParamAlignment(i);
}
- /// @brief Determine if the function cannot return.
- bool doesNotReturn() const { return paramHasAttr(0, ParamAttr::NoReturn); }
- void setDoesNotThrow(bool doesNotThrow = true);
-
- /// @brief Determine if the function cannot unwind.
- bool doesNotThrow() const {
- return paramHasAttr(0, ParamAttr::NoUnwind);
- }
-
/// @brief Determine if the function does not access memory.
bool doesNotAccessMemory() const {
return paramHasAttr(0, ParamAttr::ReadNone);
}
+ void setDoesNotAccessMemory(bool doesNotAccessMemory = true) {
+ if (doesNotAccessMemory) addParamAttr(0, ParamAttr::ReadNone);
+ else removeParamAttr(0, ParamAttr::ReadNone);
+ }
/// @brief Determine if the function does not access or only reads memory.
bool onlyReadsMemory() const {
return doesNotAccessMemory() || paramHasAttr(0, ParamAttr::ReadOnly);
}
+ void setOnlyReadsMemory(bool onlyReadsMemory = true) {
+ if (onlyReadsMemory) addParamAttr(0, ParamAttr::ReadOnly);
+ else removeParamAttr(0, ParamAttr::ReadOnly | ParamAttr::ReadNone);
+ }
+
+ /// @brief Determine if the function cannot return.
+ bool doesNotReturn() const {
+ return paramHasAttr(0, ParamAttr::NoReturn);
+ }
+ void setDoesNotReturn(bool doesNotReturn = true) {
+ if (doesNotReturn) addParamAttr(0, ParamAttr::NoReturn);
+ else removeParamAttr(0, ParamAttr::NoReturn);
+ }
+
+ /// @brief Determine if the function cannot unwind.
+ bool doesNotThrow() const {
+ return paramHasAttr(0, ParamAttr::NoUnwind);
+ }
+ void setDoesNotThrow(bool doesNotThrow = true) {
+ if (doesNotThrow) addParamAttr(0, ParamAttr::NoUnwind);
+ else removeParamAttr(0, ParamAttr::NoUnwind);
+ }
/// @brief Determine if the function returns a structure through first
/// pointer argument.
Modified: llvm/trunk/lib/VMCore/Function.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/Function.cpp?rev=53228&r1=53227&r2=53228&view=diff
==============================================================================
--- llvm/trunk/lib/VMCore/Function.cpp (original)
+++ llvm/trunk/lib/VMCore/Function.cpp Tue Jul 8 04:41:30 2008
@@ -113,18 +113,15 @@
/// addAttr - Add a ParamAttr to an argument
void Argument::addAttr(ParameterAttributes attr) {
- getParent()->setParamAttrs(
- getParent()->getParamAttrs().addAttr(getArgNo() + 1, attr));
+ getParent()->addParamAttr(getArgNo() + 1, attr);
}
-
+
/// removeAttr - Remove a ParamAttr from an argument
void Argument::removeAttr(ParameterAttributes attr) {
- getParent()->setParamAttrs(
- getParent()->getParamAttrs().removeAttr(getArgNo() + 1, attr));
+ getParent()->removeParamAttr(getArgNo() + 1, attr);
}
-
//===----------------------------------------------------------------------===//
// Helper Methods in Function
//===----------------------------------------------------------------------===//
@@ -231,18 +228,15 @@
BasicBlocks.clear(); // Delete all basic blocks...
}
-void Function::setDoesNotThrow(bool doesNotThrow) {
+void Function::addParamAttr(unsigned i, ParameterAttributes attr) {
PAListPtr PAL = getParamAttrs();
- if (doesNotThrow)
- PAL = PAL.addAttr(0, ParamAttr::NoUnwind);
- else
- PAL = PAL.removeAttr(0, ParamAttr::NoUnwind);
+ PAL = PAL.addAttr(i, attr);
setParamAttrs(PAL);
}
-void Function::addParamAttr(unsigned i, ParameterAttributes attr) {
+void Function::removeParamAttr(unsigned i, ParameterAttributes attr) {
PAListPtr PAL = getParamAttrs();
- PAL = PAL.addAttr(i, attr);
+ PAL = PAL.removeAttr(i, attr);
setParamAttrs(PAL);
}
More information about the llvm-commits
mailing list