[llvm-commits] [llvm] r52677 - in /llvm/trunk: lib/Transforms/IPO/DeadArgumentElimination.cpp test/Transforms/DeadArgElim/2008-06-23-DeadAfterLive.ll test/Transforms/DeadArgElim/deadretval2.ll test/Transforms/DeadArgElim/multdeadretval.ll

[Evan Cheng]

Hi Matthijs,

This patch works. But I didn't pay close attention to its impact on  
performance and compile time. Did you run it on MultiSource/ 
Applications? Do you see any real difference in either cateogry?

Thanks,

Evan

On Jul 2, 2008, at 9:11 AM, Matthijs Kooijman wrote:

> Hi all,
>
> I've attached a new patch, which removes an overzealous assert which  
> was not
> appropriated. Even, could you try _this_ patch against SPEC 2006?
>
>> I'm not completely sure how to do the reverse. I think the best  
>> approach is to
>> add a getArgumentNo() method that takes an operand number and  
>> returns the
>> number of the corresponding argument. Alternatively, it could take  
>> a use
>> iterator, Value* or Use* or something like that, but I think that  
>> will mostly
>> lead to inefficient code.
> I've implemented this, see the attached patch (all changes in  
> CallSite.h). If
> there are no objections to this, I'll commit the CallSite changes  
> seperately.
>
> Gr.
>
> Matthijs
> <deadarg.diff>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits