[llvm-commits] [llvm-gcc-4.2] r53079 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

[Duncan Sands]

Hi Chris,

> +/// LocalLLVMValueIDs - This is the set of local IDs we have in our mapping,
> +/// this allows us to efficiently identify and remove them.

how about adding an explanation of what a local value is?

> +    if (Value *V = LLVMValues[Idx]) {
> +      assert(!isa<Constant>(V) && "Found local value");

Shouldn't this be "Found global value!"?

Ciao,

Duncan.