[llvm-commits] [llvm] r52970 - /llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp

David Greene dag at cray.com
Tue Jul 1 13:07:25 PDT 2008


On Tuesday 01 July 2008 12:59, Evan Cheng wrote:
> Author: evancheng
> Date: Tue Jul  1 12:59:20 2008
> New Revision: 52970
>
> URL: http://llvm.org/viewvc/llvm-project?rev=52970&view=rev
> Log:
> Apply Chris' suggestion.

Evan,

This is not a very helpful log message.  It's very necessary that we be
able to do 'svn blame' and friends to find out why a particular piece of
code is the way it is.  Without a helpful log message, we can't do that.

This goes for everyone, Evan just happened to be the one caught
today.  :)

Also, it's a little weird to read replies like, "Thanks to <devname> for
help on this!" in log messages as one walks through svn history.
No harm, really, just a bit jolting at times.

                                                -Dave



More information about the llvm-commits mailing list