[llvm-commits] [llvm] r52916 - /llvm/trunk/include/llvm/Analysis/Dominators.h

[Bill Wendling]

Hi Owen,


--- llvm/trunk/include/llvm/Analysis/Dominators.h (original)
> +++ llvm/trunk/include/llvm/Analysis/Dominators.h Mon Jun 30  
> 15:28:02 2008
> @@ -792,6 +792,10 @@
>      DT->splitBlock(NewBB);
>    }
>
> +  bool isReachableFromEntry(BasicBlock* A) {
> +    return DT->isReachableFromEntry(A);
> +  }
> +
Can this be constified? Also, there's some code in that header file  
like this:

     for (i = 0; i < PredBlocks.size(); ++i)

This is wasteful. You can assign PredBlocks.size() to a variable if  
the size isn't changed in the loop.

Thanks!
-bw