[llvm-commits] [llvm] r52921 - /llvm/trunk/lib/CodeGen/PrologEpilogInserter.cpp

[Evan Cheng]

Hi Dale,

This check doesn't jive with the comment:

FFI->getObjectIndexEnd() != 0))) {

When getObjectIndexEnd() is equal to zero, it means there are non "non- 
fixed" objects. It can still have fixed objects. Can you clarify what  
it is you are checking?

Thanks,

Evan

On Jun 30, 2008, at 1:40 PM, Dale Johannesen wrote:

> Author: johannes
> Date: Mon Jun 30 15:40:16 2008
> New Revision: 52921
>
> URL: http://llvm.org/viewvc/llvm-project?rev=52921&view=rev
> Log:
> No need to align the stack if there are no stack
> objects.  Fixes a couple of tests on Linux.
>
>
> Modified:
>    llvm/trunk/lib/CodeGen/PrologEpilogInserter.cpp
>
> Modified: llvm/trunk/lib/CodeGen/PrologEpilogInserter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/PrologEpilogInserter.cpp?rev=52921&r1=52920&r2=52921&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/lib/CodeGen/PrologEpilogInserter.cpp (original)
> +++ llvm/trunk/lib/CodeGen/PrologEpilogInserter.cpp Mon Jun 30  
> 15:40:16 2008
> @@ -464,7 +464,8 @@
>   // works.
>   if (!RegInfo->targetHandlesStackFrameRounding() &&
>       (FFI->hasCalls() || FFI->hasVarSizedObjects() ||
> -       RegInfo->needsStackRealignment(Fn))) {
> +       (RegInfo->needsStackRealignment(Fn) &&
> +        FFI->getObjectIndexEnd() != 0))) {
>     // If we have reserved argument space for call sites in the  
> function
>     // immediately on entry to the current function, count it as  
> part of the
>     // overall stack size.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits