[llvm-commits] [llvm] r52603 - /llvm/trunk/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp

[Dan Gohman]

Author: djg
Date: Sat Jun 21 17:05:24 2008
New Revision: 52603

URL: http://llvm.org/viewvc/llvm-project?rev=52603&view=rev
Log:
canClobberPhysRegDefs shouldn't called without checking hasPhysRegDefs;
check this with an assert.

Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp?rev=52603&r1=52602&r2=52603&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp Sat Jun 21 17:05:24 2008
@@ -1572,15 +1572,14 @@
 }
 
 /// canClobberPhysRegDefs - True if SU would clobber one of SuccSU's
-/// physical register def.
+/// physical register defs.
 static bool canClobberPhysRegDefs(SUnit *SuccSU, SUnit *SU,
                                   const TargetInstrInfo *TII,
                                   const TargetRegisterInfo *TRI) {
   SDNode *N = SuccSU->Node;
   unsigned NumDefs = TII->get(N->getTargetOpcode()).getNumDefs();
   const unsigned *ImpDefs = TII->get(N->getTargetOpcode()).getImplicitDefs();
-  if (!ImpDefs)
-    return false;
+  assert(ImpDefs && "Caller should check hasPhysRegDefs");
   const unsigned *SUImpDefs =
     TII->get(SU->Node->getTargetOpcode()).getImplicitDefs();
   if (!SUImpDefs)