[llvm-commits] [llvm] r52432 - /llvm/trunk/lib/VMCore/Instructions.cpp

[Chris Lattner]

On Jun 17, 2008, at 2:07 PM, Dan Gohman wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=52432&view=rev
> Log:
> Implement the ExtractValueInst::getIndexedType that accepts one
> index value.

Hey Dan:

> +const Type* ExtractValueInst::getIndexedType(const Type *Agg,
> +                                             const unsigned Idx) {

How about just "unsigned Idx".

>
> +  const unsigned Idxs[1] = { Idx };
> +  return getIndexedType(Agg, &Idxs[0], 1);

Why not just:
> +  return getIndexedType(Agg, &Idx, 1);

-Chris