[llvm-commits] XPASS's

Matthijs Kooijman matthijs at stdin.nl
Mon Jun 16 02:42:50 PDT 2008


Hi Chris,

These tests were failing for me, but as Dale also reported, they don't give
warnings on darwin. I don't fully understand the testcases or warnings, so I
can't really tell what the correct solution would be.

> What is going on with these?  I see some discussion in PR2452 about 
> warnings.  However, warnings shouldn't affect tests in llvm/test unless the 
> run line for the test has -Werror on it or something.
Recently, I changed the tester such that stderr output is interpreted as a
failure. Though that's not strictly a good idea, I couldn't make TCL
distinguish between stderr output and command line parse errors, and those
last should really not be ignored.

Still, it's probably a good idea to error out on stderr output, in a lot of
cases this will mean trivial stuff needs to fixed, but it will also catch some
cases of testcases that will stop working for whatever reason.

Simply redirecting stderr to /dev/null will also restore the original
behaviour and can be done on a per testcase basis.

Gr.

Matthijs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20080616/b1d07cd8/attachment.sig>


More information about the llvm-commits mailing list