[llvm-commits] [llvm] r51937 - in /llvm/trunk: include/llvm/Instructions.h lib/VMCore/Instructions.cpp

[Dan Gohman]

Hi Matthijs,

This patch looks good. Just one stylistic comment below.

On Jun 4, 2008, at 7:40 AM, Matthijs Kooijman wrote:
>
>   ExtractValueInst(const ExtractValueInst &EVI);
> -  void init(Value *Agg, const unsigned *Idx, unsigned NumIdx);
> -  void init(Value *Agg, unsigned Idx);
> +  void init(Value *Agg, const unsigned *Idx, unsigned NumIdx, const  
> std::string &Name);


>   InsertValueInst(const InsertValueInst &IVI);
> -  void init(Value *Agg, Value *Val, const unsigned *Idx, unsigned  
> NumIdx);
> -  void init(Value *Agg, Value *Val, unsigned Idx);
> +  void init(Value *Agg, Value *Val, const unsigned *Idx, unsigned  
> NumIdx, const std::string &Name);

>
> -void ExtractValueInst::init(Value *Agg, const unsigned *Idx,  
> unsigned NumIdx) {
> +void ExtractValueInst::init(Value *Agg, const unsigned *Idx,  
> unsigned NumIdx, const std::string &Name) {

Please adjust these lines to be within 80 columns.

Thanks!

Dan