[llvm-commits] [llvm] r51947 - in /llvm/trunk/lib: Analysis/IPA/CallGraph.cpp Transforms/IPO/DeadArgumentElimination.cpp

[Matthijs Kooijman]

Hi Chris,

> Actually, this can be checked in O(1) time by just calling  
> I.getOperandNo().  If the use_iterator is for the callee operand of  
> the function, then it is ok.  If not,  you know it is passing in the  
> address of the function.  The DeadArgElim code was written before  
> getOperandNo() existed on use_iterator.
Sounds better, I'll change it to that way tomorrow.

But, how about functions that have themselves as an argument? Or would that
solve itself because then both operands (callee and argument) would be in the
use list seperately? Must be the last one, so it sounds safe to change this.

Gr.

Matthijs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20080604/c9c13583/attachment.sig>