[llvm-commits] [llvm] r51806 - in /llvm/trunk: docs/LangRef.html include/llvm/Constants.h include/llvm/DerivedTypes.h include/llvm/Instructions.h lib/AsmParser/llvmAsmParser.cpp.cvs lib/AsmParser/llvmAsmParser.h.cvs lib/AsmParser/llvmAsmParser.y lib/AsmParser/llvmAsmParser.y.cvs lib/Bitcode/Reader/BitcodeReader.cpp lib/Bitcode/Writer/BitcodeWriter.cpp lib/VMCore/Constants.cpp lib/VMCore/Instructions.cpp lib/VMCore/Type.cpp test/Assembler/insertextractvalue.ll

[Dan Gohman]

Hi Matthijs,

This looks good; please commit it.

I agree the setName situation is a little inconsistent. This
code is actually modeled after the getelementptr code which
works the same way. Would you mind preparing a patch to
fix this?

Thanks,

Dan

On Jun 2, 2008, at 6:39 AM, Matthijs Kooijman wrote:

> Hi Dan,
>
> there are still some constructors missing, find a patch for them  
> attached.
>
> With that patch applied, I can succesfully create extractvalue and  
> insertvalue
> instructions with a single index. I only tested the InsertBefore  
> variants, but
> I guess the InsertAtEnd should work identically.
>
> I'm not really sure if that setName should be there, it's a bit  
> weird that one
> of the init methods does set the name, but the others don't. Perhaps  
> adding a
> Name argument to all init methods is better?
>
> Gr.
>
> Matthijs
> <insertextract.diff>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits