[llvm-commits] [llvm] r51863 - in /llvm/trunk: include/llvm/Analysis/ValueTracking.h lib/Analysis/ValueTracking.cpp lib/Transforms/Scalar/InstructionCombining.cpp

[Dan Gohman]

On Jun 1, 2008, at 6:18 PM, Chris Lattner wrote:

> Author: lattner
> Date: Sun Jun  1 20:18:21 2008
> New Revision: 51863
>
> URL: http://llvm.org/viewvc/llvm-project?rev=51863&view=rev
> Log:
> move ComputeMaskedBits, MaskedValueIsZero, and ComputeNumSignBits
> out of instcombine into a new file in libanalysis.  This also teaches
> ComputeNumSignBits about the number of sign bits in a constantint.

Hi Chris,

ComputeNumSignBits has fallback code that uses ComputeMaskedBits
to compute a result for any node that it doesn't have special
logic for. That logic should have handled ConstantInt; was it
failing to do so?

Dan