[llvm-commits] [llvm] r51013 - /llvm/trunk/docs/LangRef.html

[Chris Lattner]

On May 23, 2008, at 3:01 PM, Dan Gohman wrote:
>> Since the indices are constants, not "Value*"'s, I don't think  
>> there should be a type specified for them.  Something like:
>>
>> %result = extractvalue {{i32, float}} %agg, 0, 1
>>
>> Should be enough.
>
> Currently the indices are Value*'s though. As Value*'s they are
> more consistent with getelementptr, and to some degree extractelement.
> Making them plain constants would make extractvalue/insertvalue a
> little simpler though, so I could be convinced :-).

I'd strongly prefer it that way.  The reason we went this way for  
getresult is that it is more memory efficient (4 bytes vs 12 [plus the  
constant itself if not shared] for each index) and it doesn't allow  
constant exprs to be used.

Does that seem reasonable?

-Chris