[llvm-commits] [llvm] r51474 - in /llvm/trunk: lib/Transforms/Scalar/InstructionCombining.cpp test/Transforms/InstCombine/2008-05-22-FoldAddIVec.ll

[Nick Lewycky]

Author: nicholas
Date: Thu May 22 23:34:58 2008
New Revision: 51474

URL: http://llvm.org/viewvc/llvm-project?rev=51474&view=rev
Log:
Revert X + X --> X * 2 optz'n which pessimizes heavily on x86.

Removed:
    llvm/trunk/test/Transforms/InstCombine/2008-05-22-FoldAddIVec.ll
Modified:
    llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp?rev=51474&r1=51473&r2=51474&view=diff

==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/InstructionCombining.cpp Thu May 22 23:34:58 2008
@@ -2292,22 +2292,14 @@
 
 namespace {
 
-// AddRHS - Implements: X + X --> X << 1 and X + X --> X * 2 for vectors
+// AddRHS - Implements: X + X --> X << 1
 struct AddRHS {
   Value *RHS;
   AddRHS(Value *rhs) : RHS(rhs) {}
   bool shouldApply(Value *LHS) const { return LHS == RHS; }
   Instruction *apply(BinaryOperator &Add) const {
-    if (Add.getType()->getTypeID() == Type::VectorTyID) {
-      const VectorType *VTy = cast<VectorType>(Add.getType());
-      ConstantInt *CI = ConstantInt::get(VTy->getElementType(), 2);
-      std::vector<Constant*> Elts(VTy->getNumElements(), CI);
-      return BinaryOperator::CreateMul(Add.getOperand(0),
-                                       ConstantVector::get(Elts));
-    } else {
-      return BinaryOperator::CreateShl(Add.getOperand(0),
-                                       ConstantInt::get(Add.getType(), 1));
-    }
+    return BinaryOperator::CreateShl(Add.getOperand(0),
+                                     ConstantInt::get(Add.getType(), 1));
   }
 };
 
@@ -2635,8 +2627,8 @@
     }
   }
 
-  // X + X --> X << 1 and X + X --> X * 2 for vectors
-  if (I.getType()->isIntOrIntVector() && I.getType() != Type::Int1Ty) {
+  // X + X --> X
+  if (I.getType()->isInteger() && I.getType() != Type::Int1Ty) {
     if (Instruction *Result = AssociativeOpt(I, AddRHS(RHS))) return Result;
 
     if (Instruction *RHSI = dyn_cast<Instruction>(RHS)) {

Removed: llvm/trunk/test/Transforms/InstCombine/2008-05-22-FoldAddIVec.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/2008-05-22-FoldAddIVec.ll?rev=51473&view=auto

==============================================================================
--- llvm/trunk/test/Transforms/InstCombine/2008-05-22-FoldAddIVec.ll (original)
+++ llvm/trunk/test/Transforms/InstCombine/2008-05-22-FoldAddIVec.ll (removed)
@@ -1,6 +0,0 @@
-; RUN: llvm-as < %s | opt -instcombine | llvm-dis | grep mul
-
-define <3 x i8> @f(<3 x i8> %i) {
-  %A = add <3 x i8> %i, %i
-  ret <3 x i8> %A
-}