[llvm-commits] [llvm] r51409 - /llvm/trunk/lib/VMCore/InlineAsm.cpp

Chris Lattner sabre at nondot.org
Wed May 21 21:46:38 PDT 2008


Author: lattner
Date: Wed May 21 23:46:38 2008
New Revision: 51409

URL: http://llvm.org/viewvc/llvm-project?rev=51409&view=rev
Log:
Fix PR2267, by allowing indirect outputs to be intermixed
with normal outputs.  Testcase here: 
test/CodeGen/X86/asm-indirect-mem.ll

Modified:
    llvm/trunk/lib/VMCore/InlineAsm.cpp

Modified: llvm/trunk/lib/VMCore/InlineAsm.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/InlineAsm.cpp?rev=51409&r1=51408&r2=51409&view=diff

==============================================================================
--- llvm/trunk/lib/VMCore/InlineAsm.cpp (original)
+++ llvm/trunk/lib/VMCore/InlineAsm.cpp Wed May 21 23:46:38 2008
@@ -183,15 +183,18 @@
   if (Constraints.empty() && !ConstStr.empty()) return false;
   
   unsigned NumOutputs = 0, NumInputs = 0, NumClobbers = 0;
+  unsigned NumIndirect = 0;
   
   for (unsigned i = 0, e = Constraints.size(); i != e; ++i) {
     switch (Constraints[i].Type) {
     case InlineAsm::isOutput:
+      if ((NumInputs-NumIndirect) != 0 || NumClobbers != 0)
+        return false;  // outputs before inputs and clobbers.
       if (!Constraints[i].isIndirect) {
-        if (NumInputs || NumClobbers) return false;  // outputs come first.
         ++NumOutputs;
         break;
       }
+      ++NumIndirect;
       // FALLTHROUGH for Indirect Outputs.
     case InlineAsm::isInput:
       if (NumClobbers) return false;               // inputs before clobbers.





More information about the llvm-commits mailing list