[llvm-commits] Patch for llvm-ar, llvm-ranlib creating files with wrong? file access rights

[Mikael Lepistö]

On May 15, 2008, at 11:40, Duncan Sands wrote:

> On Thursday 15 May 2008 22:25:45 Owen Anderson wrote:
>> On May 15, 2008, at 4:57 AM, Mikael Lepistö wrote:
>>> +  if (archPath.makeWriteableOnDisk(ErrMsg))
>>> +    return true;
>>> +
>>>
>>
>> I don't understand why you're making it writable.  The permission  
>> that
>> normal ar sets are rw-r--r--.
>
> On unix machines the usual thing is to pass ugo+rw to open, and it
> will be masked with the current umask to produce (usually) something
> tighter like rw-r--r--.  Dunno how this should be done in LLVM.

That is how the patch worked at least on my linux box. Archives were
still created with -rw-r--r-- rights. Actually baldrick instructed to
use gou+rw rights on irc channel :)

- mikael