[llvm-commits] [llvm] r51132 - /llvm/trunk/lib/Support/APFloat.cpp

[Neil Booth]

Evan Cheng wrote:-

> Well, sorry about introducing a bug. Obviously the patch isn't intended to 
> fix a bug. It's meant to suppress compile time warnings (with -m64 
> -Wshorten-64-to-32). Unfortunately it's a strict requirement for some.
>
>>
>>
>> Could you review carefully every line of your patch to see if it
>> hasn't introduced others, or consider reverting it?
>
> If you think the patch is dangerous. Please go ahead and revert APFloat.cpp 
> portion of the patch.

Take responsibility for your own commits, particularly once they're
shown to be erroneous, and don't push that burden onto others.

Neil.