[llvm-commits] [llvm] r51140 - in /llvm/trunk: include/llvm/CodeGen/MachineFrameInfo.h include/llvm/Target/TargetLowering.h lib/CodeGen/SelectionDAG/SelectionDAG.cpp lib/Target/X86/X86ISelLowering.cpp lib/Target/X86/X86ISelLowering.h

[Duncan Sands]

Hi Evan,

> +  /// setObjectAlignment - Change the alignment of the spcified stack object...

spcified -> specified

> +  /// getOptimalMemOpType - Returns the target specific optimal type for load
> +  /// store operations as result of memset, memcpy, and memmove lowering.

load store -> load and store
as result -> as a result

>    if (ConstantSDNode *C = dyn_cast<ConstantSDNode>(Value)) {
> -    uint64_t Val   = C->getValue() & 255;
> +    APInt Val = APInt(NumBits, C->getValue() & 255);

It seems a bit silly to demote from an APInt to a uint64_t (C->getValue)
then turn it back into an APInt again...

> +/// getOptimalMemOpType - Returns the target specific optimal type for load
> +/// store operations as result of memset, memcpy, and memmove lowering.

Likewise.

> +    /// getOptimalMemOpType - Returns the target specific optimal type for load
> +    /// store operations as result of memset, memcpy, and memmove lowering.

Likewise.

Ciao,

Duncan.