[llvm-commits] [llvm] r51013 - /llvm/trunk/docs/LangRef.html

[Duncan Sands]

Hi Dan,

> +The '<tt>extractvalue</tt>' instruction extracts a value
> +from an aggregate value.

it may not be clear to people what it means to extract a value...

> +The first operand of an '<tt>extractvalue</tt>' instruction is a
> +value of <a href="#t_struct">struct</a> or <a href="#t_array">array</a>
> +type.  The operands are constant indicies to specify which value to extract
> +in the same manner as indicies in a

... so how about explaining that this means extracting a field from a struct
and an element from an array.

Also, indicies -> indices 

> +The first operand of an '<tt>insertvalue</tt>' instruction is a
> +value of <a href="#t_struct">struct</a> or <a href="#t_array">array</a> type.
> +The second operand is a first-class value to insert.
> +type of the first operand.  The following operands are constant indicies
> +indicating the position at which to insert the value in the same manner as
> +indicies in a

Likewise.

> +The value to insert must have the same type as the value identified
> +by the indicies.

indicies -> indices.  This occurs later on too.

Ciao,

Duncan.