[llvm-commits] paths on win32

[Nick Lewycky]

There's a problem on win32 where Paths can be created with \'s as path 
separators in them. The win32 sys::Path implementation normally 
canonicalize them into /'s, but using the constructor will bypass that. 
This is a problem because clients expect to be able to take any valid 
win32 path (which may have any mix of / and \) and construct a valid 
Path with it, through the constructor.

This patch moves the constructor implementations out of 
include/llvm/System/Path.h and into lib/System/*/Path.inc. This fixes 
the bug, but there may be a small price in efficiency. Is this approach 
okay? (There are two other ways to fix the bug.)

Nick

-------------- next part --------------
A non-text attachment was scrubbed...
Name: win32-path.patch
Type: text/x-diff
Size: 2152 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20080511/8c7b5cb6/attachment.patch>